Skip to content
This repository was archived by the owner on Dec 30, 2022. It is now read-only.
This repository was archived by the owner on Dec 30, 2022. It is now read-only.

[BUG] Unable to launch MC after failed mod update (Windows) #137

Closed
@Felix14-v2

Description

@Felix14-v2

Description
After unsuccessfully downloading new versions of the mod, you may get an error and the update will fail. However, an empty file of the new mod will be created, which will lead to an error loading mods (see screenshots).

To Reproduce

  1. Install outdated version of some mod
  2. Make ModManager get an error when updating it (I don't know if it's possible to do this on purpose. But in my case it was not possible to update the Fabric API and Amecs)
  3. Close the game
  4. Try to launch MC with empty mod(s) files
  5. See the error

Expected behavior
ModManager should delete empty mod files when they failed to download.

Technical Info

  • Windows 10
  • Minecraft 1.18.1
  • Fabric Loader 0.13.1
  • ModManager 1.2.2

Logs
latest.log

Additional context
Failed updating
latest.log

Screenshots

Updating error
image

Empty mod files created by MM after failed mod update
image

Fabric error screen
image

Error text Incompatible mod set! net.fabricmc.loader.impl.FormattedException: net.fabricmc.loader.impl.discovery.ModResolutionException: Mod discovery failed! at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:192) at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:142) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:71) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) Caused by: net.fabricmc.loader.impl.discovery.ModResolutionException: Mod discovery failed! at net.fabricmc.loader.impl.discovery.ModDiscoverer.lambda$discoverMods$1(ModDiscoverer.java:137) at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33) at net.fabricmc.loader.impl.discovery.ModDiscoverer.discoverMods(ModDiscoverer.java:137) at net.fabricmc.loader.impl.FabricLoaderImpl.setup(FabricLoaderImpl.java:208) at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:187) ... 3 more Caused by: java.lang.RuntimeException: java.lang.RuntimeException: Error analyzing [C:\Users\Александр\AppData\Roaming\.minecraft\home\Fabric 1.18\mods\fabric-api-0.46.4+1.18.jar]: java.util.zip.ZipException: zip file is empty at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480) at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:562) at java.base/java.util.concurrent.ForkJoinTask.reportExecutionException(ForkJoinTask.java:604) at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:981) at net.fabricmc.loader.impl.discovery.ModDiscoverer.discoverMods(ModDiscoverer.java:134) ... 5 more Caused by: java.lang.RuntimeException: Error analyzing [C:\Users\Александр\AppData\Roaming\.minecraft\home\Fabric 1.18\mods\fabric-api-0.46.4+1.18.jar]: java.util.zip.ZipException: zip file is empty at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:237) at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:194) at java.base/java.util.concurrent.RecursiveTask.exec(RecursiveTask.java:100) at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) Caused by: java.util.zip.ZipException: zip file is empty at java.base/java.util.zip.ZipFile$Source.zerror(ZipFile.java:1598) at java.base/java.util.zip.ZipFile$Source.findEND(ZipFile.java:1382) at java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1477) at java.base/java.util.zip.ZipFile$Source.(ZipFile.java:1315) at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1277) at java.base/java.util.zip.ZipFile$CleanableResource.(ZipFile.java:709) at java.base/java.util.zip.ZipFile.(ZipFile.java:243) at java.base/java.util.zip.ZipFile.(ZipFile.java:172) at java.base/java.util.zip.ZipFile.(ZipFile.java:186) at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.computeJarFile(ModDiscoverer.java:262) at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:232) ... 7 more

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingduplicateThis issue or pull request already exists

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions