CI Workflow and Dependency Management Improvements: #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am defaulting to onnx ir version 10 for now, unless onnxruntime version is too old. It looks like latest onnx package spits out IR version 11 but onnxruntime hasn't updated to support it yet.
I think the read and exec'ing of keras_model.py in keras_to_MDF.py might be causing some deadlocks in tensorflow on macos. Testing ...
This should cancel running CI jobs if there are new pushes.
The tensorflow examples load keras_model.py from the local direcotry and exec this. Instead, I have them import from the local dir. I think this might fix a race condition on macos tensorflow, we will see.
Trying to see if we have an import issue.
Too many status checks to check for branch protection rule. This consolidates everything to one job that checks for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes significant improvements to the CI workflow configuration and refines how dependencies are installed for builds. The main changes include restructuring the GitHub Actions workflow to better organize and parallelize test jobs, updating dependency installation methods. It also drops Python 3.9 support and adds 3.13 to testing. Package pins on onnxruntime and torchviz have been removed as well.
CI Workflow and Dependency Management Improvements:
.github/workflows/ci.ymlto use a matrix strategy for test jobs, enabling parallel testing across multiple Python versions, operating systems, and test suites. Also replaced pip-based installs withuv syncfor dependency management, and added a concurrency group to prevent overlapping runs. [1] [2]docs/sphinx/requirements.txtto use--group=docsfor compatibility withuv, replacing the previous[optional]extras syntax.