This repository has been archived by the owner on May 30, 2021. It is now read-only.
Fix shared options between instances of DataTables #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using multiple data tables in a HTML, it seems that options for each instances are shared.
I discover it is because of the
defaultConfig
object is broken changed when creating DataTable instances.Example
Expected
table1
has set default perPage = 25.table2
has set default perPage = 10(default).table1
has 2 records.table2
has no records.Actual(before fixed by this PR)
table1
has set default perPage = 25.table2
has set default perPage = 25.table1
has 2 records.table2
has 2 records.