Skip to content

fix: using ServiceIntervalCache to compute the service window - #2130

Merged
cka-y merged 2 commits into
masterfrom
test/sw
Mar 9, 2026
Merged

fix: using ServiceIntervalCache to compute the service window#2130
cka-y merged 2 commits into
masterfrom
test/sw

Conversation

@cka-y

@cka-y cka-y commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Summary:

Updated computation of the service due to found discrepancy detailed here.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y added the do not merge This PR needs more work/discussion or is not meant to be merged label Mar 9, 2026
@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 89c3eb6
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1000 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1000 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1000 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1000 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

3 out of 1003 sources (~0 %) are corrupted.
Dataset Ref Report Exists Ref Report Readable Latest Report Exists Latest Report Readable
mdb-1114
mdb-1123
mdb-9
🔍 System errors for mdb-1114 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1114 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1123 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1123 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-9 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-9 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]

💾 Out of Memory Check

No datasets experienced an OutOfMemoryError.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 5.27 5.68 ⬆️+0.41
Median -- 1.64 1.92 ⬆️+0.28
Standard Deviation -- 18.75 21.76 ⬆️+3.01
Minimum in References Reports mdb-2360 0.47 0.58 ⬆️+0.11
Maximum in Reference Reports mdb-2014 491.17 608.15 ⬆️+116.99
Minimum in Latest Reports mdb-2235 0.50 0.52 ⬆️+0.02
Maximum in Latest Reports mdb-2014 491.17 608.15 ⬆️+116.99
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 558.10 MiB 561.38 MiB ⬆️+3.28 MiB
Median -- 327.93 MiB 323.93 MiB ⬇️-4.00 MiB
Standard Deviation -- 982.83 MiB 1019.03 MiB ⬆️+36.19 MiB
Minimum in References Reports mdb-77 39.40 MiB 39.39 MiB ⬇️-3.95 KiB
Maximum in Reference Reports mdb-2014 8.47 GiB 8.66 GiB ⬆️+188.36 MiB
Minimum in Latest Reports mdb-77 39.40 MiB 39.39 MiB ⬇️-3.95 KiB
Maximum in Latest Reports mdb-2014 8.47 GiB 8.66 GiB ⬆️+188.36 MiB

@cka-y

cka-y commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

Service Window Diagnostic — mdb-1934

While testing feed mdb-1934 with this branch, I found a discrepancy in the computed service window compared to main. main reports the feed starts on April 21st, 2025, but the actual start date is April 22nd, 2025. Detailed breakdown below. 👇

Feed: mdb-1934-202603060110
Issue: main computes start date as April 21, 2025 but feed actually starts April 22, 2025

📁 Detailed Breakdowns

Full per-service details are attached as CSVs:

Each file contains: service_id, active, source_file, csv_row, explanation.

@cka-y cka-y changed the title test: service window class change fix: using ServiceIntervalCache to compute the service window Mar 9, 2026
@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit ef7bd1a
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1000 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1000 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1000 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1000 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

3 out of 1003 sources (~0 %) are corrupted.
Dataset Ref Report Exists Ref Report Readable Latest Report Exists Latest Report Readable
mdb-1114
mdb-1123
mdb-9
🔍 System errors for mdb-1114 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1114 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1123 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1123 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-9 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-9 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]

💾 Out of Memory Check

No datasets experienced an OutOfMemoryError.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 5.35 5.67 ⬆️+0.33
Median -- 1.62 1.92 ⬆️+0.30
Standard Deviation -- 21.34 22.68 ⬆️+1.33
Minimum in References Reports mdb-518 0.47 0.61 ⬆️+0.14
Maximum in Reference Reports mdb-2014 587.70 638.48 ⬆️+50.78
Minimum in Latest Reports mdb-1788 0.51 0.50 ⬇️-0.00
Maximum in Latest Reports mdb-2014 587.70 638.48 ⬆️+50.78
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 565.59 MiB 554.68 MiB ⬇️-10.91 MiB
Median -- 323.93 MiB 327.93 MiB ⬆️+4.00 MiB
Standard Deviation -- 1014.74 MiB 951.24 MiB ⬇️-63.51 MiB
Minimum in References Reports mdb-745 39.07 MiB 39.08 MiB ⬆️+4.04 KiB
Maximum in Reference Reports mdb-2014 8.65 GiB 8.65 GiB ⬆️+4.49 MiB
Minimum in Latest Reports mdb-745 39.07 MiB 39.08 MiB ⬆️+4.04 KiB
Maximum in Latest Reports mdb-2014 8.65 GiB 8.65 GiB ⬆️+4.49 MiB

@davidgamez davidgamez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cka-y
cka-y merged commit bba15b7 into master Mar 9, 2026
103 checks passed
@cka-y
cka-y deleted the test/sw branch March 9, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge This PR needs more work/discussion or is not meant to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants