feat: 2050 add notice for pathways to stop with stop access1 - #2104
Conversation
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 8649792 📊 Notices ComparisonNew Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check16 out of 1003 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
… of github.com:MobilityData/gtfs-validator into 2050-add-notice-for-pathways-to-stop-with-stop_access1
🚨 Code Formatting Issue 🚨This contribution does not follow the conventions set by the Google Java Style Guide. Please run the following command at the root of the project to fix formatting errors: ./gradlew spotlessApply🗂️ Affected files
Go to the Actions Dashboard to download the full Spotless output |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 795e98b 📊 Notices ComparisonNew Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check16 out of 1003 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit d133dcb 📊 Notices ComparisonNew Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check16 out of 1003 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
| @Override | ||
| public boolean shouldCallValidate() { | ||
| return stopTable.hasColumn(STOP_ACCESS_FIELD_NAME) | ||
| && stopTable.hasColumn(PLATFORM_CODE_FIELD_NAME); |
There was a problem hiding this comment.
You can still validate if there is no platform code, no?
It's just that it there will be no platform code in the notice, but the rest of the info is valid.
🚨 Code Formatting Issue 🚨This contribution does not follow the conventions set by the Google Java Style Guide. Please run the following command at the root of the project to fix formatting errors: ./gradlew spotlessApply🗂️ Affected files
Go to the Actions Dashboard to download the full Spotless output |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 8350eb4 📊 Notices ComparisonNew Errors (1 out of 987 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check16 out of 1003 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 480bca9 📊 Notices ComparisonNew Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check16 out of 1003 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 00c7ee8 📊 Notices ComparisonNew Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check16 out of 1003 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
…thwayStopAccessValidator.java Co-authored-by: David Gamez <1192523+davidgamez@users.noreply.github.com>
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 7b28547 📊 Notices ComparisonNew Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check16 out of 1003 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
|
Used this chatgpt generated dataset on the staging web validator and it worked well. Moving to Done |
4 participants
Summary:
Closes #2050
Expected behavior:
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything