Skip to content

feat: added cars allowed feature - #2091

Merged
cka-y merged 7 commits into
masterfrom
feat/2075
Feb 23, 2026
Merged

feat: added cars allowed feature#2091
cka-y merged 7 commits into
masterfrom
feat/2075

Conversation

@cka-y

@cka-y cka-y commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Summary:

This pull request adds support for detecting the presence of the "Cars Allowed" feature in GTFS feeds by checking for the cars_allowed field in trip records. The change ensures that the feature is included in the feed's metadata summary if at least one record contains this field.

image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y added the do not merge This PR needs more work/discussion or is not meant to be merged label Feb 9, 2026
@cka-y

cka-y commented Feb 9, 2026

Copy link
Copy Markdown
Contributor Author

This PR needs documentation change on gtfs.org to be fully tested.

@cka-y cka-y linked an issue Feb 9, 2026 that may be closed by this pull request
@cka-y
cka-y marked this pull request as ready for review February 23, 2026 14:20
@cka-y cka-y removed the do not merge This PR needs more work/discussion or is not meant to be merged label Feb 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 99ad0f5
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (1 out of 987 datasets, ~0%) ✅

Details of new errors due to code change, which is less than the provided threshold of 1%.

Dataset Notice Code
mdb-2014 csv_parsing_failed
New Warnings (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

16 out of 1003 sources (~2 %) are corrupted.
Dataset Ref Report Exists Ref Report Readable Latest Report Exists Latest Report Readable
mdb-1114
mdb-1123
mdb-1332
mdb-1808
mdb-1953
mdb-227
mdb-383
mdb-55
mdb-606
mdb-609
mdb-655
mdb-780
mdb-789
mdb-806
mdb-9
mdb-907

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 5.31 5.31 ⬆️+0.00
Median -- 1.59 1.66 ⬆️+0.08
Standard Deviation -- 21.13 18.92 ⬇️-2.21
Minimum in References Reports mdb-518 0.43 0.51 ⬆️+0.08
Maximum in Reference Reports mdb-2014 574.96 491.28 ⬇️-83.68
Minimum in Latest Reports mdb-1788 0.48 0.49 ⬆️+0.01
Maximum in Latest Reports mdb-2014 574.96 491.28 ⬇️-83.68
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 566.79 MiB 563.27 MiB ⬇️-3.52 MiB
Median -- 323.93 MiB 327.93 MiB ⬆️+4.00 MiB
Standard Deviation -- 1015.22 MiB 1009.63 MiB ⬇️-5.59 MiB
Minimum in References Reports mdb-77 39.31 MiB 45.76 MiB ⬆️+6.45 MiB
Maximum in Reference Reports mdb-2014 8.24 GiB 8.47 GiB ⬆️+231.22 MiB
Minimum in Latest Reports mdb-61 411.93 MiB 41.85 MiB ⬇️-370.08 MiB
Maximum in Latest Reports mdb-2014 8.24 GiB 8.47 GiB ⬆️+231.22 MiB

cka-y and others added 2 commits February 23, 2026 10:15
Co-authored-by: jcpitre <106176106+jcpitre@users.noreply.github.com>
@github-actions

This comment was marked as duplicate.

@github-actions

This comment was marked as outdated.

@github-actions

Copy link
Copy Markdown
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 3e26a2a
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

16 out of 1003 sources (~2 %) are corrupted.
Dataset Ref Report Exists Ref Report Readable Latest Report Exists Latest Report Readable
mdb-1114
mdb-1123
mdb-1332
mdb-1808
mdb-1953
mdb-227
mdb-383
mdb-55
mdb-606
mdb-609
mdb-655
mdb-780
mdb-789
mdb-806
mdb-9
mdb-907

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 5.38 5.46 ⬆️+0.08
Median -- 1.60 1.67 ⬆️+0.07
Standard Deviation -- 21.30 20.80 ⬇️-0.50
Minimum in References Reports mdb-906 0.45 0.54 ⬆️+0.08
Maximum in Reference Reports mdb-2014 573.28 554.79 ⬇️-18.48
Minimum in Latest Reports mdb-6 0.47 0.48 ⬆️+0.00
Maximum in Latest Reports mdb-2014 573.28 554.79 ⬇️-18.48
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 565.81 MiB 562.66 MiB ⬇️-3.15 MiB
Median -- 324.16 MiB 323.93 MiB ⬇️-243.54 KiB
Standard Deviation -- 1011.53 MiB 984.56 MiB ⬇️-26.97 MiB
Minimum in References Reports mdb-2329 41.87 MiB 57.70 MiB ⬆️+15.84 MiB
Maximum in Reference Reports mdb-2393 8.58 GiB 8.25 GiB ⬇️-332.50 MiB
Minimum in Latest Reports mdb-107 44.92 MiB 42.05 MiB ⬇️-2.87 MiB
Maximum in Latest Reports mdb-2014 8.29 GiB 8.48 GiB ⬆️+187.74 MiB

@cka-y
cka-y requested a review from jcpitre February 23, 2026 16:40
@cka-y
cka-y merged commit 0d2778f into master Feb 23, 2026
105 checks passed
@cka-y
cka-y deleted the feat/2075 branch February 23, 2026 16:48
@github-actions

Copy link
Copy Markdown
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 3dd7cd3
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (1 out of 987 datasets, ~0%) ✅

Details of new errors due to code change, which is less than the provided threshold of 1%.

Dataset Notice Code
mdb-2014 csv_parsing_failed
Dropped Errors (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

16 out of 1003 sources (~2 %) are corrupted.
Dataset Ref Report Exists Ref Report Readable Latest Report Exists Latest Report Readable
mdb-1114
mdb-1123
mdb-1332
mdb-1808
mdb-1953
mdb-227
mdb-383
mdb-55
mdb-606
mdb-609
mdb-655
mdb-780
mdb-789
mdb-806
mdb-9
mdb-907

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 5.48 5.62 ⬆️+0.14
Median -- 1.58 1.76 ⬆️+0.17
Standard Deviation -- 22.56 21.96 ⬇️-0.59
Minimum in References Reports mdb-1105 0.48 0.55 ⬆️+0.06
Maximum in Reference Reports mdb-2014 617.87 598.72 ⬇️-19.16
Minimum in Latest Reports mdb-6 0.51 0.50 ⬇️-0.01
Maximum in Latest Reports mdb-2014 617.87 598.72 ⬇️-19.16
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 567.05 MiB 554.99 MiB ⬇️-12.05 MiB
Median -- 323.93 MiB 323.93 MiB ⬇️0 bytes
Standard Deviation -- 1009.13 MiB 971.77 MiB ⬇️-37.36 MiB
Minimum in References Reports mdb-61 40.02 MiB 40.02 MiB ⬆️+24 bytes
Maximum in Reference Reports mdb-2393 8.95 GiB 8.55 GiB ⬇️-412.00 MiB
Minimum in Latest Reports mdb-77 41.02 MiB 39.33 MiB ⬇️-1.69 MiB
Maximum in Latest Reports mdb-2393 8.95 GiB 8.55 GiB ⬇️-412.00 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Cars Allowed feature

2 participants