fix: hide the note if the expiration date is equal to the expected date. - #2039
fix: hide the note if the expiration date is equal to the expected date.#2039przemekwrona wants to merge 5 commits into
Conversation
|
Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:
|
|
|
| @Test | ||
| public void feedExpiring30DaysFromNowShouldGenerateNotice() { | ||
| assertThat(validateFeedInfo(createFeedInfo(GtfsDate.fromLocalDate(TEST_NOW.plusDays(30))))) | ||
| public void feedExpiring29DaysFromNowShouldGenerateNotice() { |
There was a problem hiding this comment.
Suggestion to modify to feedExpiringAfter30DaysFromNowShouldGenerateNotice instead to conform to the actual guidance from the spec: "If possible, the GTFS dataset should cover at least the next 30 days of service." https://gtfs.org/documentation/schedule/reference/#dataset-publishing-general-practices
|
Thanks for working on this clarification @przemekwrona! One minor suggested change. |
| } | ||
|
|
||
| @Test | ||
| public void feedExpiring30DaysFromNowShouldGenerateNotice() { |
There was a problem hiding this comment.
Shouldn't it be feedExpiring30DaysFromNowShouldNotGenerateNotice:
| public void feedExpiring30DaysFromNowShouldGenerateNotice() { | |
| public void feedExpiring30DaysFromNowShouldNotGenerateNotice() { |
| } | ||
|
|
||
| @Test | ||
| public void feedExpiring31DaysFromNowShouldGenerateNotice() { |
There was a problem hiding this comment.
| public void feedExpiring31DaysFromNowShouldGenerateNotice() { | |
| public void feedExpiring31DaysFromNowShouldNotGenerateNotice() { |
|
Hi @przemekwrona, Thanks for your contribution. |
|
This PR has been replaced by #2125 |
5 participants
Summary:
Issue #2039
While validating a GTFS feed, I received the following message:
feedEndDate: 20250712, suggestedExpirationDate: 20250712
This message is confusing because the suggestedExpirationDate is the same as the feedEndDate, which might imply that the feed is expiring exactly when it ends — but no further action or recommendation is provided. It's unclear whether this is intended or if the feed should include more future service dates.
Expected behavior:
If the dates are the same and no issue is present, the validator should not flag this message as a warning or should clarify that the feed is valid until its last service date.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything