feat: added fare_leg_join_rules.txt schema and validation
#1956
Conversation
|
This is close to covering #1932 as well if |
|
@emmambd
is there a check that needs to be modified/added to cover #1932? |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 207ef2e 📊 Notices ComparisonNew Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1801 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
| * </ul> | ||
| */ | ||
| @GtfsValidator | ||
| public class FareLegJoinRuleValidator extends FileValidator { |
There was a problem hiding this comment.
Let's include shouldCallValidate(logic based on the missing file method). This does not improve performance, but it's good practice. We can get a log on why some validators don't run without digging too deeply into the code.
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit a90fef1 📊 Notices ComparisonNew Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1801 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit e6bbc44 📊 Notices ComparisonNew Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1801 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
|
@cka-y everything looks good, just one detail I'd like to double check with you and @emmambd. For We might want to show |
|
@skalexch if i'm understanding properly, you're suggesting to change the display order of the notices so that |
|
@cka-y I'm suggesting the addition of another |
|
Currently the logic is:
I think the current logic does cover your suggestion but I could be mistaking. |
|
@cka-y the However, from_network_id and to_network_id are required regardless of each other. So even before proceeding to validating the FK, from_network_id and to_network_id both need to exist. Basically, this should trigger a
|
|
Looks good! |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 4700a7a 📊 Notices ComparisonNew Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1801 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Summary:
fare_leg_join_rules.txtschema.network_idfound infare_leg_join_rules.txtmatches an entry innetworks.txtorroutes.txt.from_stop_idorto_stop_idis present but the other is omitted, ensuring both are supplied consistently.Expected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything