Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validator for ferry trips + bikes allowance #1510

Merged
merged 4 commits into from
Jul 4, 2023
Merged

feat: validator for ferry trips + bikes allowance #1510

merged 4 commits into from
Jul 4, 2023

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Jun 20, 2023

Summary:

Add a rule with a WARNING severity level that checks is bike_allowed is present for ferry trips, after the addition in MobilityData/GTFS_Schedule_Best-Practices#55.
Closes #1499

Expected behavior:

missing_bike_allowance warning notice is added to the report if ferry route types don't specify the bikes_allowed value. Valid values are 1 (bikes allowed) and 2 (bikes not allowed). Any value different from 1 or 2 will result in the warning being present in the report.

image

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y requested a review from isabelle-dr June 20, 2023 18:42
@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 1 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 80 out of 1430 datasets (~6%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: 6b2aac2
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@isabelle-dr
Copy link
Contributor

Thank you for working on this!
This looks great 👍.

@isabelle-dr
Copy link
Contributor

@davidgamez, does this PR have any dependencies with the automatic generation of documentation?

RULES.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 80 out of 1435 datasets (~6%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 2decc04
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 80 out of 1435 datasets (~6%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: efb5d30
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@cka-y cka-y requested review from jcpitre and davidgamez July 3, 2023 18:08
@jcpitre
Copy link
Contributor

jcpitre commented Jul 3, 2023

@cka-y I think it would be worthwhile to verify that the failing acceptance tests are consistant with the change in the code and were expected.
In such a situation I would say it's good practice to explain the test failures in a PR comment.

@cka-y
Copy link
Contributor Author

cka-y commented Jul 3, 2023

Since we introduced a new warning notice, some acceptance tests are failing.
After examination of the evaluation report, I can confirm that all differences are expected and related to the newly added warning notice.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 80 out of 1435 datasets (~6%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: baa073c
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@cka-y cka-y merged commit ec14841 into master Jul 4, 2023
@cka-y cka-y deleted the issue/1499 branch July 4, 2023 16:04
davidgamez pushed a commit that referenced this pull request Jul 5, 2023
* feat: validator for ferry trips + bike allocation

* feat: removed "info" suffix

* feat: fixed formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update validator with new Best Practice (bike_allowed present for ferry trips)
4 participants