Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Conditionally run more multi-file validators if their dependencies don't have parse errors #1496

Merged
merged 6 commits into from
Jun 13, 2023

Conversation

bdferris-v2
Copy link
Collaborator

This is an initial exploration for issue #1484. Not ready for check-in yet.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

❌ Invalid acceptance test.
New Errors: 38 out of 1430 datasets (~3%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 63 out of 1430 datasets (~4%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: 70d1908
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@bdferris-v2 bdferris-v2 marked this pull request as ready for review June 9, 2023 21:21
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

❌ Invalid acceptance test.
New Errors: 37 out of 1430 datasets (~3%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 63 out of 1430 datasets (~4%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: 9991cfe
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@davidgamez
Copy link
Member

❌ Invalid acceptance test. New Errors: 37 out of 1430 datasets (~3%) are invalid due to code change, which is above the provided threshold of 1%. Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. New Warnings: 63 out of 1430 datasets (~4%) are invalid due to code change, which is above the provided threshold of 1%. Dropped Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. 0 out of 1430 sources (~0 %) are corrupted. Commit: 9991cfe Download the full acceptance test report here (report will disappear after 90 days). ❌ Invalid acceptance test.

I reviewed the new add warnings and errors, and they are generated from the FileValidators previously ignored. So this is behaving as expected.

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 37 out of 1430 datasets (~3%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 65 out of 1430 datasets (~5%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: 14e7c88
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 36 out of 1430 datasets (~3%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 66 out of 1430 datasets (~5%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: 25343b2
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@davidgamez davidgamez merged commit 8e9127a into master Jun 13, 2023
@davidgamez davidgamez deleted the issue/1484/more_validators branch June 13, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants