-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a few missing "Affected files" references #1427
Conversation
… first parsing pass of RULES.md.
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
✅ Rule acceptance tests passed. |
One question that is probably out of scope for this PR: Also, we might want to have |
@isabelle-dr a couple points:
Does that make sense? There is a bit of an edge-case where for the "https://gtfs.org/best-practices/#dataset-publishing--general-practices" link. I suppose I could update that to be a section ref? As for @FileRefs vs @UrlRef, the difference is intentional. Namely, @FileRefs can contain an array of values, such that you can specify:
I didn't want to go with
Compare that to
It doesn't make as much sense to do Looking back, I think I had imagined adding more fields to
getting rid of |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reliably parsing
RULES.md
is an inexact science and I missed a few "Affected files" references in my first automated pass due to inconsistent formatting inRULES.md
. This PR adds them in. Part of #1324.Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything