Skip to content

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Jan 30, 2026

Change Summary

Upgrading Spark/Airflow/OL/etc versions will lead to storing both old and new versions as job tags. To fix that, for job tags we keep only new tag_values and delete old ones because they are outdated. Except when job was received without any tags, this is expected for parent jobs, and we left tags intact.

This is not the case for dataset tags as there can be multiple sources of dataset tags, and there is no way to determine if tag value is outdated or not.

Ideally, this should be implemented as run_tag_value table, but there are issues with this approach, with a lack of user demand on pet-run tags feature.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Jan 30, 2026
@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Jan 30, 2026
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

Coverage

Coverage Report •
FileStmtsMissCoverMissing
data_rentgen/db/repositories
   job.py86198%231
TOTAL757292387% 

@dolfinus dolfinus marked this pull request as ready for review January 30, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants