-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.13 #227
base: main
Are you sure you want to change the base?
Support Python 3.13 #227
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 60 +15
Lines 2242 4033 +1791
===========================================
+ Hits 2242 4033 +1791 ☔ View full report in Codecov by Sentry. |
1152e98
to
384dfcc
Compare
6e6d193
to
40e3b71
Compare
40e3b71
to
d37e414
Compare
23bfe8f
to
2d5ccf3
Compare
@feldlime Applied all the feedback, and CI passed. PTAL |
Co-authored-by: Emiliy Feldman <feldlime@yandex.ru>
For nmslib, I created Python 3.13 support PR at metabrainz/nmslib-metabrainz#5 |
Test failure is due to upload coverage failure https://github.com/MobileTeleSystems/RecTools/actions/runs/12814286663/job/35730351993
|
PyTorch will support Python 3.13 on January 29. |
@chezou I think we can use the new version of |
No, I don't think so. While PyTorch 2.6 supports Python 3.13, pytorch-lighning hasn't supported PyTorch 2.6 nor Python 3.13 yet. There's no issue or PR for Python 3.13 yet. We may need to wait for a while, but should be addressed in another PR. |
PyTorch Lightning here, we'll be supporting PyTorch 2.6 and Python 3.13 shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, we can consider this PR is done, let's wait for the support from lightning (it's important since 2 transformer models are almost ready) and we can merge it
If we could merge it, that'd be great since I'm a bit tired of updating CHANGLONG for two months. If other two transformer models come soon, I can wait. |
@lantiga Can you share the GitHub issue for Python 3.13 support if it exists? It'd be much easier to take an action for it. |
Description
Support Python 3.13 excluding:
PyTorch will likely support Python 3.13 in the coming months.
nmslib-metabrainz only supports until Python 3.12.
Type of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.