Repository navigation
Copy frameworks according to product ownership - #3367
Draft
karim-alweheshy wants to merge 2 commits into
Draft
karim-alweheshy wants to merge 2 commits into
karim-alweheshy wants to merge 2 commits into
Conversation
Validate sources and destinations before staging. Track native Preview sibling links by target, source and inode so refreshes preserve real products and other targets. Keep legacy bundle staging and native product ownership distinct. The native path remains inactive until a Preview configuration opts in. Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
Signed-off-by: Karim Alweheshy <9082720+karim-alweheshy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage framework dependencies according to product ownership. Preserve Xcode-owned products while preparing Bazel-owned frameworks for native Preview use; cover collisions, ownership changes, and regeneration.
Stack
Based on #3358, whose updated head is incorporated. Land #3358 first, then reconcile and revalidate this branch against
main; do not merge into the feature base.Validation
The framework-copy Bazel target executed and passed on the updated candidate. ShellCheck and whitespace checks passed. Coverage uses synthetic framework products, including a declared-rsync case; it does not establish real Canvas behavior or full-stack compatibility.
Testing
Run
bazel test //test/internal/bazel_integration_files:preview_framework_scripts.