Repository navigation
Fix owned explicit-module graphs for Xcode indexing - #3362
Draft
karim-alweheshy wants to merge 3 commits into
Draft
karim-alweheshy wants to merge 3 commits into
karim-alweheshy wants to merge 3 commits into
Conversation
added 2 commits
September 23, 2026 20:57
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
karim-alweheshy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize Bazel-owned explicit-module graphs for Xcode indexing and pass their metadata to the indexing compiler-argument consumer. Preserve ordinary compiler flags and keep generated toolchain paths portable.
Stack
Based on #3359. Review against that prerequisite; land it first, then retarget and rerun validation against
main.Validation
The diff adds generator tests for owned explicit-module arguments and Starlark tests for the corresponding input contract. Hosted checks reported success on the published head in the 2026-10-08 snapshot.
Testing
Run
bazel test //tools/generators/target_build_settings:target_build_settings_tests //test/internal/pbxproj_partials:swift_explicit_inputs. This is indexing preparation, not a Preview Canvas claim.