Repository navigation
Prepare and stage resource bundles for native Previews - #3354
Draft
karim-alweheshy wants to merge 1 commit into
Draft
karim-alweheshy wants to merge 1 commit into
karim-alweheshy wants to merge 1 commit into
Conversation
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output locations, preserving bundle-relative paths for app- and
library-owned Previews.
and recover interrupted moves without deleting resources owned elsewhere.
Based on branch
preview-stack-native-previews-v2. This adds resource-bundlesupport to its resource-free native Preview opt-in without changing ordinary
Bazel-owned configurations.
Review order
producers, nested paths, asset catalogs and localization inputs.
broutput groups and generated bundle-path settings:check the contract for app, library and mixed-language targets.
and destinations fail without overwriting unowned files.
Validation
This resegmented branch has exactly the same Git tree as the previously
CLI-validated candidate. Root tests and lint are rerun at this head. The example
CLI/build/staging evidence below is reused from that identical tree, not claimed
as a new execution during this split.
proposed head on macOS with Xcode 27.0. Repository Buildifier passes.
inputs, asset catalogs, output-group ownership, conflicts and interrupted
migrations. Changed copy/staging shell scripts pass ShellCheck.
Previews-configuration CLI builds pass for library, framework, explicit-module,
macOS app and generic iOS Simulator schemes with signing disabled.
iOS app bundle, and library-product sibling bundle; each bundle plist validates.
These are build/staging checks. Fresh Canvas rendering, runtime resource lookup
and signed-runtime verification remain pending for this extracted stack.
Testing
ownership, and interrupted-migration cases.
Preview and a library-owned Preview; verify staged bundle contents and runtime
lookup at the intended bundle location.
the expected view renders and loads its resource. A successful build or
staged-file check alone does not establish Canvas rendering.