Repository navigation
Add opt-in native Xcode Preview configurations - #3353
Draft
karim-alweheshy wants to merge 1 commit into
Draft
karim-alweheshy wants to merge 1 commit into
karim-alweheshy wants to merge 1 commit into
Conversation
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selected Preview targets, while leaving ordinary configurations Bazel-owned.
macro, and linker inputs from Bazel so Xcode can compile the Preview source
with its native toolchain.
runtime-policy preparation with their native consumers in this change.
path. Resource-bundle migration/staging is handled by the follow-up resource
change.
Based on branch
preview-stack-compiler-inputs-v2.The opt-in and its required compiler/link/runtime plumbing stay together so no
intermediate merge exposes an incomplete configuration. The separate linker
and indexing improvements are already in the base. Resource bundles are outside
this chunk; the checked-in example makes that limitation explicit.
Review order
preview_xcode_configurationsoption and project/configuration settings:check that only named configurations opt in and archive attempts are rejected.
check the producer-to-consumer contract, static dependency closure, generated
headers, test hosts, frameworks, and mixed-language targets.
examples/previews: check ordinary configurationpreservation and the supported scheme/source pairings.
Validation
This resegmented branch has exactly the same Git tree as the previously
CLI-validated candidate. Root tests and lint are rerun at this head. The example
CLI/build/staging evidence below is reused from that identical tree, not claimed
as a new execution during this split.
proposed head on macOS with Xcode 27.0. Repository Buildifier passes.
rules_apple 4.4 pins, using this repository through
local_path_override.pass. An ordinary Xcode Debug build of the macOS app also passes.
framework, macOS app, explicit-module, and generic iOS Simulator schemes.
The final assembled source was regenerated and the mixed/explicit schemes
rerun. CLI builds used
CODE_SIGNING_ALLOWED=NO.from main. Generated documentation retains its required trailing blank line.
This is a draft extraction with compile/link/packaging evidence, not fresh Canvas
render or signed-runtime proof. The assembled stack still needs visual retesting.
The separate rules_swift 4.1 fixture is not included: ordinary compilation with
the installed Xcode 27 SDK crashes before a Preview action can run.
Testing
a Preview, and record the first terminal result. A successful build alone is
not a successful Preview; confirm the expected view actually renders before
making that claim.