Fix escaping to patch directories that contain the word external #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of these will no longer get a `SRCROOT` path: ``` header "../../external/bob.h" header "../external/bob.h" header "external/bob.h" header "../../bazel-out/bob.h" header "../bazel-out/bob.h" header "bazel-out/bob.h" header "bazel-out/external/bob.h" header "../bazel-out/external/bob.h" header "../external/bazel-out/bob.h" ``` but these still will: ``` header "../../bob/external/bob.h" header "../../bobexternal/bob.h" header "../../bob.h" header "bob/external/bob.h" header "../../bob/bazel-out/bob.h" header "../../bobbazel-out/bob.h" header "bob/bazel-out/bob.h" ``` https://regex101.com/r/Bd35j5/1
brentleyjones
force-pushed
the
pb/fix-escaping
branch
from
d069b18 to
eb7aec8
Compare
brentleyjones
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #279.
I ran into a case where if you have a directory that contains the word
external, it that wasn't being patched correctly, thus failing the compilation.This PR fixes it and only excludes headers in directories that start with exactly
/bazel-out/or/external/but not directories that contain/toolexternal/or/externaltool/, or have/bazel-out/or/external/later in the path.