Update Tests to Use Turbine #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
==========================================
+ Coverage 74.89% 75.43% +0.54%
==========================================
Files 38 38
Lines 920 920
Branches 168 168
==========================================
+ Hits 689 694 +5
+ Misses 144 142 -2
+ Partials 87 84 -3 |
|
Going to conflict with your latest kover pr |
matt-ramotar
force-pushed
the
matt-ramotar/turbine
branch
from
7e6565d to
f76e371
Compare
|
Were the test changes done manually or scripted/automated? If the latter, please provide what was used. |
|
@tyvsmith I updated them manually |
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
matt-ramotar
force-pushed
the
matt-ramotar/turbine
branch
from
f76e371 to
5b08906
Compare
tyvsmith
approved these changes
Feb 22, 2025
itsandreramon
pushed a commit
to itsandreramon/Store
that referenced
this pull request
Feb 26, 2025
* Update Turbine Signed-off-by: matt-ramotar <matt.ramotar@uber.com> * Update FetcherResponseTests to use Turbine Signed-off-by: matt-ramotar <matt.ramotar@uber.com> * Update FetcherResponseTests to use Turbine Signed-off-by: matt-ramotar <matt.ramotar@uber.com> * Update FlowStoreTests to use Turbine Signed-off-by: matt-ramotar <matt.ramotar@uber.com> * Update MapIndexedTests to use Turbine Signed-off-by: matt-ramotar <matt.ramotar@uber.com> * Update HotFlowStoreTests to use Turbine Signed-off-by: matt-ramotar <matt.ramotar@uber.com> * Update UpdaterTests to use Turbine Signed-off-by: matt-ramotar <matt.ramotar@uber.com> * Update SourceOfTruthErrorsTests to use Turbine Signed-off-by: matt-ramotar <matt.ramotar@uber.com> * Update ValueFetcherTests to use Turbine Signed-off-by: matt-ramotar <matt.ramotar@uber.com> * Update SourceOfTruthWithBarrierTests to use Turbine Signed-off-by: matt-ramotar <matt.ramotar@uber.com> * Update StreamWithoutSourceOfTruthTests to use Turbine Signed-off-by: matt-ramotar <matt.ramotar@uber.com> * Delete AssertEmitsExactly.kt Signed-off-by: matt-ramotar <matt.ramotar@uber.com> * Run gradlew ktlintFormat Signed-off-by: matt-ramotar <matt.ramotar@uber.com> --------- Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is updating our tests to use Turbine.