Skip to content

Fix Failing Node JS Tests #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2024
Merged

Fix Failing Node JS Tests #665

merged 3 commits into from
Oct 18, 2024

Conversation

matt-ramotar
Copy link
Collaborator

Bumping Kotlin and Coroutines resolves these failures:

> Task :cache:jsNodeTest

org.mobilenativefoundation.store.cache5.CacheTests.getIfPresent[js, node] FAILED
    TypeError at /Users/matt/src/mobilenativefoundation/Store/cache/src/commonMain/kotlin/org/mobilenativefoundation/store/cache5/LocalCache.kt:2023

org.mobilenativefoundation.store.cache5.CacheTests.getOrPut[js, node] FAILED
    TypeError at /Users/matt/src/mobilenativefoundation/Store/cache/src/commonMain/kotlin/org/mobilenativefoundation/store/cache5/LocalCache.kt:2023

org.mobilenativefoundation.store.cache5.CacheTests.getAllPresent[js, node] FAILED
    TypeError at /Users/matt/src/mobilenativefoundation/Store/cache/src/commonMain/kotlin/org/mobilenativefoundation/store/cache5/LocalCache.kt:2023

org.mobilenativefoundation.store.cache5.CacheTests.invalidate[js, node] FAILED
    TypeError at /Users/matt/src/mobilenativefoundation/Store/cache/src/commonMain/kotlin/org/mobilenativefoundation/store/cache5/LocalCache.kt:2023

org.mobilenativefoundation.store.cache5.CacheTests.maximumSize[js, node] FAILED
    TypeError at /Users/matt/src/mobilenativefoundation/Store/cache/src/commonMain/kotlin/org/mobilenativefoundation/store/cache5/LocalCache.kt:2023

org.mobilenativefoundation.store.cache5.CacheTests.maximumWeight[js, node] FAILED
    TypeError at /Users/matt/src/mobilenativefoundation/Store/cache/src/commonMain/kotlin/org/mobilenativefoundation/store/cache5/LocalCache.kt:2023

org.mobilenativefoundation.store.cache5.CacheTests.expireAfterAccess[js, node] FAILED
    TypeError at /Users/matt/src/mobilenativefoundation/Store/cache/src/commonMain/kotlin/org/mobilenativefoundation/store/cache5/LocalCache.kt:2023

org.mobilenativefoundation.store.cache5.CacheTests.expireAfterWrite[js, node] FAILED
    TypeError at /Users/matt/src/mobilenativefoundation/Store/cache/src/commonMain/kotlin/org/mobilenativefoundation/store/cache5/LocalCache.kt:2023

Reducing repetition from 1000 to 100 resolves this failure:

> Task :store:jsNodeTest

org.mobilenativefoundation.store.store5.StoreWithInMemoryCacheTests.storeDeadlock[js, node] FAILED
    Error at node:internal/timers:573

@matt-ramotar
Remove failing test
08bf8d1 
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
@matt-ramotar
Bump Kotlin, Coroutines, and AndroidX Test
a7aeb50 
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
@matt-ramotar
Add back test
175dd6a 
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
@matt-ramotar matt-ramotar mentioned this pull request Oct 18, 2024
Merged
@digitalbuddha digitalbuddha merged commit a7abd3a into main Oct 18, 2024
3 checks passed
@matt-ramotar matt-ramotar deleted the matt-ramotar/fix/store-deadlock-test branch November 17, 2024 15:16
matt-ramotar added a commit that referenced this pull request Feb 19, 2025
@matt-ramotar
Fix Failing Node JS Tests (#665)
243670f 
* Remove failing test

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

* Bump Kotlin, Coroutines, and AndroidX Test

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

* Add back test

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

---------

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
itsandreramon pushed a commit to itsandreramon/Store that referenced this pull request Feb 26, 2025
@matt-ramotar
Fix Failing Node JS Tests (MobileNativeFoundation#665)
e63caab 
* Remove failing test

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

* Bump Kotlin, Coroutines, and AndroidX Test

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

* Add back test

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

---------

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalbuddha digitalbuddha digitalbuddha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Store Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-ramotar @digitalbuddha