Skip to content

Conversation

@didix21
Copy link
Contributor

@didix21 didix21 commented May 15, 2024

Add new script Copy Bundle Resource on Krono's Build Phase and include the PrivacyInfo.xcprivacy, otherwise when running xcodebuild -create-xcframework command the manifest isn't included on Kronos.xcframework.

image image

@didix21
Copy link
Contributor Author

didix21 commented May 29, 2024

Have you had the chance to take a look at this PR, @keith @sberrevoets ?

@keith
Copy link
Member

keith commented May 31, 2024

You'll need to fix the DCO check here. But lgtm

…xcodeproj

- Add new script Copy Bundle Resource on Krono's Build Phase and include
  the PrivacyInfo.xcprivacy, otherwise when running xcodebuild
  create-xcframework command the manifest isn't included on
  Kronos.xcframework.

Signed-off-by: Dídac Coll <didac.coll@qustodio.com>
@didix21 didix21 force-pushed the fix-privacy-manifest-kronos branch from 8df8a47 to d48ac19 Compare June 3, 2024 07:46
@didix21
Copy link
Contributor Author

didix21 commented Jun 3, 2024

DCO fixed ✅

@keith keith merged commit f331821 into MobileNativeFoundation:main Jun 3, 2024
ducknology pushed a commit to ducknology/Kronos that referenced this pull request Jun 25, 2025
…xcodeproj (MobileNativeFoundation#117)

- Add new script Copy Bundle Resource on Krono's Build Phase and include
  the PrivacyInfo.xcprivacy, otherwise when running xcodebuild
  create-xcframework command the manifest isn't included on
  Kronos.xcframework.

Signed-off-by: Dídac Coll <didac.coll@qustodio.com>
Signed-off-by: Billy Chan <billy.chan@dowjones.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants