Skip to content

update devtool for webpack v5 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkrusch merged 1 commit into from
Oct 14, 2021
Merged

update devtool for webpack v5 #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cli/gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@ const clean = () => del([paths.dist + '/*']);

const script = ({src, name, mode}, done = _ => true) => {

// use mode if specified explicitly; otherwise choose by --env
const webpackOptions = {
// use mode if specified explicitly; otherwise choose by --env
mode: mode || (isProd ? 'production' : 'development'),
output: {filename: `${name}.js`}
// match sourcemap name with configured js file name
output: {filename: `${name}.js`},
// use source map with dev builds only
devtool: isProd ? undefined : 'cheap-source-map'
};

if (!isProd) webpackOptions.devtool = 'cheap-source-map';
else webpackOptions.devtool = 'none';

return gulp.src(src)
.pipe(webpack(webpackOptions))
.on('error', (err) => {
Expand Down