Disable setting RequestedAuthnContext during saml request#2580
Open
jathok wants to merge 1 commit intoMobSF:masterfrom
Open
Disable setting RequestedAuthnContext during saml request#2580jathok wants to merge 1 commit intoMobSF:masterfrom
jathok wants to merge 1 commit intoMobSF:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the Pull Request
Current Behavior
The SAML Python Toolkit request will set the RequestedAuthnContext to
'exact' 'urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport', see advanced_settings.json section for"requestedAuthnContext"if the setting is omitted or set to true.Issue
IdP services will use the RequestedAuthnContext if provided. If the session did not
exactlyusePasswordProtectedTransport, SSO login will always fail.Issue Environment
We use Azure Entra as the IdP. The login method is hardened and does not necessarily use
PasswordProtectedTransportmethod, but rather a "stronger" one.This Entra AADSTS75011 Troubleshooting article describes the issue.
Intend
The RequestAuthNContext should only be set if
Solution
Following Intend Nr. 1, I would change the security setting to enforce AT LEAST
PasswordProtectedTransport, therefore changing therequestedAuthnContextComparisonto minimum instead of exact.However, Microsoft explicitly document that Entra SAML applications do not support any other comparison but exact.
The other solution is to disable the RequestedAuthnContext entirely. Since it is optional for the Entra IdP and, from what I could find searching the net, also optional for other IdPs, I suggest to do so by default.
Checklist for PR
tox -e lint,testStaticAnalyzer/tests.py)