Tweaked BinSkim to give more results.

MobSF · Feb 26, 2017 · a1701dd · a1701dd
1 parent 05df9fa
commit a1701dd
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 10 deletions.
diff --git a/StaticAnalyzer/views/windows.py b/StaticAnalyzer/views/windows.py
@@ -330,7 +330,7 @@ def __binskim(name, bin_an_dic, run_local=False, app_dir=None):
         path = bin_path
         output_p = "-o"
         output_d = bin_path + "_binskim"
-        # verbose = "-v"
+        verbose = "-v"
         policy_p = "--config"
         policy_d = "default"  # TODO(Other policies?)
 
@@ -340,7 +340,7 @@ def __binskim(name, bin_an_dic, run_local=False, app_dir=None):
             command,
             path,
             output_p, output_d,
-            # verbose,
+            verbose,
             policy_p, policy_d
         ]
 
@@ -369,11 +369,19 @@ def __parse_binskim(bin_an_dic, output):
     if 'results' in current_run:
         rules = output['runs'][0]['rules']
         for res in current_run['results']:
-            result = {
-                "rule_id": res['ruleId'],
-                "status": "Insecure",
-                "desc": rules[res['ruleId']]['shortDescription']
-            }
+            if res['level'] != "pass":
+                result = {
+                    "rule_id": res['ruleId'],
+                    "status": "Insecure",
+                    "desc": rules[res['ruleId']]['shortDescription'],
+                    "info": res['formattedRuleMessage']["arguments"][2]
+                }
+            else:
+                result = {
+                    "rule_id": res['ruleId'],
+                    "status": "Secure",
+                    "desc": rules[res['ruleId']]['shortDescription']
+                }
             bin_an_dic['results'].append(result)
     else:
         print "[WARNING] binskim has no results."

diff --git a/install/windows/rpc_client.py b/install/windows/rpc_client.py
@@ -100,7 +100,7 @@ def binskim(sample, signature):
     path = config['MobSF']['samples'] + sample
     output_p = "-o"
     output_d = config['MobSF']['samples'] + sample + "_binskim"
-    # verbose = "-v"
+    verbose = "-v"
     policy_p = "--config"
     policy_d = "default"  # TODO(Other policies?)
 
@@ -110,7 +110,7 @@ def binskim(sample, signature):
         command,
         path,
         output_p, output_d,
-        # verbose,
+        verbose,
         policy_p, policy_d
     ]
 

diff --git a/templates/static_analysis/windows_binary_analysis.html b/templates/static_analysis/windows_binary_analysis.html
@@ -218,7 +218,7 @@ <h3 class="box-title"><i class="fa fa-mobile"></i> Binary Analysis</h3>
                           <th>ISSUE</th>
                           <th>STATUS</th>
                           <th>DESCRIPTION</th>
-
+                          <th>INFO</th>
                       </tr>
                   </thead>
                   <tbody>
@@ -239,6 +239,7 @@ <h3 class="box-title"><i class="fa fa-mobile"></i> Binary Analysis</h3>
                           </span>
                         </td>
                         <td>{{ result.desc }}</td>
+                        <td>{{ result.info }}</td>
                       </tr>
                     {% endfor %}
                     {% for warn in bin_an_warnings %}
@@ -250,6 +251,7 @@ <h3 class="box-title"><i class="fa fa-mobile"></i> Binary Analysis</h3>
                         </span>
                       </td>
                       <td>{{ warn.desc }}</td>
+                      <td>{{ warn.info }}
                     </tr>
                     {% endfor %}
                     </tbody>