add buffer to FEMU Blackbox #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR. I notice that the LRU cache is currently only triggered by flash writes. Would adding missed read requests to the flash cache also enhance performance? If so, could you consider using dirty labels to differentiate between clean pages and those requiring write-back during eviction? |
|
Sorry for the late response. After I adding missed read request to the flash cache, it actually increase the hit ratio constantly after several time of reading. And for the using dirty labels, I'm sorry could you please elaborate more? Do i just need to add label for the pages that needs to be evicted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented buffer mechanism in FEMU Blackbox, I also add interface configuration for setting its buffer size and buffer threshold