[feature] 동아리 부스 클릭시 이동되게 변경#1313
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Warning
|
| Cohort / File(s) | Summary |
|---|---|
라우팅 변경 frontend/src/App.tsx |
/webview/club/@:clubName 라우트 추가; ClubDetailPage를 ContentErrorBoundary로 감싸 렌더링. |
이벤트 상수 frontend/src/constants/eventName.ts |
USER_EVENT에 FESTIVAL_BOOTH_CLICKED 상수 추가. |
부스 상호작용 & 데이터 frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.tsx |
부스 객체에 선택적 link 필드 추가 및 다수 부스 항목에 값 추가. 부스 렌더러에 클릭 핸들러 및 포인터 스타일 추가, 클릭 시 믹스패널 이벤트 전송 및 isInAppWebView() 결과에 따라 /webview/club/{link} 또는 /clubDetail/{link}로 navigate 호출. useNavigate, isInAppWebView, useEffect 등 import 추가. |
스토리북 frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.stories.tsx |
MemoryRouter 도입 및 Story에 decorators로 라우팅 컨텍스트 제공. |
Sequence Diagram(s)
sequenceDiagram
actor User
participant BoothMapSection as BoothMapSection
participant Analytics as Mixpanel
participant Router as ReactRouter
participant ClubDetailPage as ClubDetailPage
User->>BoothMapSection: 부스 클릭 (link)
BoothMapSection->>Analytics: FESTIVAL_BOOTH_CLICKED 이벤트 전송
BoothMapSection->>BoothMapSection: isInAppWebView() 확인
alt 웹뷰 환경
BoothMapSection->>Router: navigate("/webview/club/@" + clubName)
else 일반 웹 환경
BoothMapSection->>Router: navigate("/clubDetail/" + clubName)
end
Router->>ClubDetailPage: 클럽 상세 페이지 렌더링
ClubDetailPage-->>User: 클럽 정보 표시
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
- [release] FE v1.1.20 #1116: App.tsx의 클럽 상세 라우트 추가/수정과 직접 중복되는 라우팅 변경 가능성.
- [feature] 동아리 한글 표시 이름 추가 -FE #1233: "@:clubName" 스타일 라우트 추가 및 라우팅/네비게이션 관련 변경과 연관.
- [fix] 지원서 목록이 항상 비어있던 문제 수정 #1306: 이름 기반 라우팅 vs id 기반 처리와 관련된 클럽 상세 네비게이션 변경 사항과 코드 레벨 연관성.
Suggested labels
✨ Feature, 💻 FE
Suggested reviewers
- seongwon030
- oesnuj
- suhyun113
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | PR 제목이 변경 사항의 주요 목표를 명확하게 반영하고 있습니다. '동아리 부스 클릭시 이동되게 변경'은 부스 클릭 시 상세 페이지로의 네비게이션 추가라는 핵심 변경 사항을 정확히 설명합니다. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
feature/navigate-to-clubdetail
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.tsx`:
- Line 1: The import list in BoothMapSection.tsx includes useEffect which is not
used; remove useEffect from the import statement (keep useState if still used)
in the BoothMapSection component's import line to eliminate the unused import,
or if side-effect logic is intended, instead use useEffect inside the
BoothMapSection function to implement that behavior and then keep the import.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 83633abe-bd06-49bb-9711-372ede638e32
📒 Files selected for processing (3)
frontend/src/App.tsxfrontend/src/constants/eventName.tsfrontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.tsx
🎨 UI 변경사항을 확인해주세요
1개 스토리 변경 · 전체 58개 스토리 · 23개 컴포넌트 |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.stories.tsx (1)
1-26:⚠️ Potential issue | 🟡 MinorPrettier 포맷팅 경고 해결 필요
파이프라인에서 코드 스타일 이슈가 발견되었습니다. 머지 전에 포맷팅을 수정해 주세요.
npx prettier --write frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.stories.tsx🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.stories.tsx` around lines 1 - 26, Prettier formatting errors in BoothMapSection.stories.tsx need fixing; run the suggested formatter (npx prettier --write frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.stories.tsx) or apply project Prettier rules to reformat the file, preserving the existing export const meta = { ... } satisfies Meta<typeof BoothMapSection> block, the MemoryRouter decorator and Story component wrapper without changing semantics. Ensure imports (Meta, StoryObj, MemoryRouter, 'swiper/css', BoothMapSection) remain correctly ordered and no trailing commas/spacing issues remain so the file passes CI lint/format checks.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In
`@frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.stories.tsx`:
- Around line 1-26: Prettier formatting errors in BoothMapSection.stories.tsx
need fixing; run the suggested formatter (npx prettier --write
frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.stories.tsx)
or apply project Prettier rules to reformat the file, preserving the existing
export const meta = { ... } satisfies Meta<typeof BoothMapSection> block, the
MemoryRouter decorator and Story component wrapper without changing semantics.
Ensure imports (Meta, StoryObj, MemoryRouter, 'swiper/css', BoothMapSection)
remain correctly ordered and no trailing commas/spacing issues remain so the
file passes CI lint/format checks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ff65f13b-4c1f-4590-9a7c-cd69880b672b
📒 Files selected for processing (1)
frontend/src/pages/FestivalPage/components/BoothMapSection/BoothMapSection.stories.tsx
2 participants
#️⃣연관된 이슈
📝작업 내용
보이는 동아리 부스 클릭시 해당 동아리의 상세페이지로 이동되게 변경하였습니다.
참여하는 모든동아리 정상적으로 이동되는것 확인했습니다.
중점적으로 리뷰받고 싶은 부분(선택)
논의하고 싶은 부분(선택)
🫡 참고사항
Summary by CodeRabbit
새로운 기능
향상 사항
사소한 변경