Skip to content

[feature] 한국어 라우팅 추가 수정#1266

Merged
lepitaaar merged 2 commits into
develop-fefrom
feature/add-korean-routing
Feb 28, 2026
Merged

[feature] 한국어 라우팅 추가 수정#1266
lepitaaar merged 2 commits into
develop-fefrom
feature/add-korean-routing

Conversation

@lepitaaar
Copy link
Copy Markdown
Contributor

@lepitaaar lepitaaar commented Feb 28, 2026

📝작업 내용

한국어 라우팅 URI 인코딩 추가
에러바운더리 추가

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

Bug Fixes

  • 클럽 상세 페이지의 오류 처리 강화
  • 특수 문자가 포함된 클럽 이름의 URL 인코딩 개선

@lepitaaar lepitaaar self-assigned this Feb 28, 2026
@lepitaaar lepitaaar added ✨ Feature 기능 개발 💻 FE Frontend labels Feb 28, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
moadong Ready Ready Preview, Comment Feb 28, 2026 3:41pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 28, 2026

Caution

Review failed

The pull request is closed.

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2c26e54 and 032639e.

📒 Files selected for processing (3)
  • frontend/src/App.tsx
  • frontend/src/pages/ApplicationFormPage/ApplicationFormPage.tsx
  • frontend/src/pages/MainPage/components/ClubCard/ClubCard.tsx

Walkthrough

클럽 상세 페이지 라우트를 ContentErrorBoundary로 감싸고, 네비게이션 시 클럽명을 encodeURIComponent로 인코딩하는 변경. 총 3개 파일에서 URL 인코딩 로직 추가 및 에러 핸들링 강화.

Changes

Cohort / File(s) Summary
에러 바운더리 래핑
frontend/src/App.tsx
'/clubDetail/@:clubName' 라우트를 ContentErrorBoundary로 감싸서 에러 처리 개선.
URL 인코딩
frontend/src/pages/ApplicationFormPage/ApplicationFormPage.tsx, frontend/src/pages/MainPage/components/ClubCard/ClubCard.tsx
네비게이션 시 clubDetail.name과 club.name을 encodeURIComponent로 인코딩하여 특수문자 포함된 클럽명 처리.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • seongwon030
  • oesnuj
✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/add-korean-routing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@seongwon030 seongwon030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 해결 감사합니다

@lepitaaar lepitaaar merged commit ade9567 into develop-fe Feb 28, 2026
2 of 4 checks passed
@seongwon030 seongwon030 deleted the feature/add-korean-routing branch May 22, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FE Frontend ✨ Feature 기능 개발

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants