Zabezpieczenie formularza do dodawania książek, podatność XSS #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-Site Scripting
Gdzie: Formularz dodawania książki: POST /books/create/
Możliwe było wprowadzenie złośliwego kodu JavaScript w polu Name. W tym przypadku
<script>alert("hacked_by_xss")</script>, który był zapisywany i wykonywany po odświeżeniu strony.Sposób odtworzenia:
<script>alert("hacked_by_xss")</script>Zaproponowane rozwiązanie
W pliku: project/books/views.py, w funkcji create_book() użyto markupsafe.escape.
Zastosowano:
name = escape(request.form.get('name'))author = escape(request.form.get('author'))year_published = escape(request.form.get('year_published'))book_type = escape(request.form.get('book_type’))Taki kod finalnie nie będzie wykonywalny, ponieważ jest zapisywany jako zwykły tekst.

Po ponownym
Po zapisaniu alert się nie pojawia, a rekord zostaje pusty.