Skip to content

Conversation

@s0ders
Copy link
Contributor

@s0ders s0ders commented Jan 16, 2026

Fixes parsing issue on Windows. Should fix issue 155.

@MituuZ
Copy link
Owner

MituuZ commented Jan 17, 2026

@s0ders thanks for the fix suggestion. I'll verify that everything works on my end

I'm guessing there might be something different about our setups?

I've been running this with rg on windows 11 since the first implementation without any issues. My file paths are relative and do not include the drive letter at all

Scratch that, the absolute path should be cleared on RipGrep.parseOutputLine. Could you check how the projectBasePath replace is working on your system?

@s0ders
Copy link
Contributor Author

s0ders commented Jan 17, 2026

On my end, when using relative path target, the drive letter is not present in projectBasePath. However, with absolute path target, it is (e.g., C:/Users/user/Desktop/fuzzier_fork\src\main\...\BackendStrategy.kt:31:1:..., note the mixed slashes).

@MituuZ
Copy link
Owner

MituuZ commented Jan 17, 2026

Yeah, I think this an acceptable fallback solution when the base path handling fails even if it doesn't touch the base path stripping

I'm hoping #154 can get rid of OS specific path handling, though it might not be so straightforward

@s0ders
Copy link
Contributor Author

s0ders commented Jan 17, 2026

Yes #154 would be, in my opinion, a better and cleaner solution. But as of now, I think this PR should be a sufficient temporary fix

@MituuZ
Copy link
Owner

MituuZ commented Jan 17, 2026

Will be included in the next version

Do you mind a shoutout on the changenotes?

@s0ders
Copy link
Contributor Author

s0ders commented Jan 17, 2026

Great! Be my guest :)

@MituuZ MituuZ merged commit 6fda275 into MituuZ:main Jan 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

May I ask, grep shows no content

2 participants