Added support for glob patterns (* and ?) in SSH config Include directive parser. #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccanoe
force-pushed
the
ssh-config-include-glob
branch
from
b19909f to
fa2fa6c
Compare
|
@ccanoe can you rebase and let's see if the tests pass, thanks |
ccanoe
force-pushed
the
ssh-config-include-glob
branch
from
fa2fa6c to
bc08c60
Compare
|
It seems glob.h is not available on Windows, which causes a build error. I’m implementing a cross-platform alternative using filesystem and std::regex |
ccanoe
force-pushed
the
ssh-config-include-glob
branch
from
5cb237e to
45402ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for glob patterns (* and ?) in the Include directive of the SSH config parser used by Eternal Terminal.
This enables the inclusion of multiple SSH config files using wildcard patterns, matching OpenSSH behavior for directives like:
Include ~/.ssh/config.d/*.conf
Include host_?.conf
Tested locally with various pattern combinations and confirmed correct parsing and connection behavior.