update secrets handling to support multiple secrets per mcp server

[j4ys0n]

backwards compatible implementation, no change to mcp servers as tool calls were already compatible.

[j4ys0n]

Automated review 🤖

1. Summary of Changes
   This pull request updates the secrets handling mechanism in the MCP API to support multiple secrets per server while maintaining backward compatibility. It introduces a new secretNames field alongside the existing secretName field, migrates existing servers from the old format to the new one, and ensures that both formats are handled gracefully during server creation and updates. The changes are designed to be non-breaking and transparent to existing users.

2. Findings & Recommendations

[package.json] - Version bump to 1.8.0
Resolution: No action needed. This is a standard version increment for a new feature release.

[src/controllers/mcp.ts] - Exclusion of secretName from response
Resolution: No action needed. The controller correctly excludes the deprecated secretName field from responses, ensuring that only the new secretNames format is returned.

[src/services/mcp.ts] - Migration logic for secret names
Resolution: No action needed. The migration logic is well-implemented and handles the transition from the old secretName format to the new secretNames format seamlessly. It also persists the migration to the database asynchronously, preventing blocking operations.

[src/services/mcp.ts] - Normalization of secret names during server creation
Resolution: No action needed. The normalization logic correctly prioritizes secretNames over secretName for backward compatibility, ensuring that new servers are created with the correct format.

[src/services/mcp.ts] - Normalization of secret names during server updates
Resolution: No action needed. The update logic correctly normalizes secret names, ensuring that both old and new formats are handled appropriately during updates.

3. Approval Status
   Status: Approved
   Reasoning: The pull request introduces a well-designed and backward-compatible enhancement to the secrets handling mechanism, with appropriate migration strategies and clear separation of concerns. The code is clean, well-documented, and addresses the stated objective effectively.