Skip to content

Add posibility to download custom dir #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleksl0l wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add posibility to download custom dir #228

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78f6be0
Add custom_dir argument to `scrape_bandcamp_url` function
aleksl0l Apr 12, 2019
34e9653
Add pass arguments for scrape_bandcamp_url
aleksl0l Apr 12, 2019
6ebfd9d
Get kwargs safety
aleksl0l Apr 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions soundscrape/soundscrape.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,13 @@ def process_bandcamp(vargs):
else:
bc_url = 'https://' + artist_url + '.bandcamp.com/music'

filenames = scrape_bandcamp_url(bc_url, num_tracks=vargs['num_tracks'], folders=vargs['folders'], custom_path=vargs['path'])
filenames = scrape_bandcamp_url(
bc_url,
num_tracks=vargs.get('num_tracks'),
folders=vargs.get('folders'),
custom_path=vargs.get('path'),
custom_dir=vargs.get('custom_dir')
)

# check if we have lists inside a list, which indicates the
# scraping has gone recursive, so we must format the output
Expand All @@ -565,7 +571,7 @@ def process_bandcamp(vargs):


# Largely borrowed from Ronier's bandcampscrape
def scrape_bandcamp_url(url, num_tracks=sys.maxsize, folders=False, custom_path=''):
def scrape_bandcamp_url(url, num_tracks=sys.maxsize, folders=False, custom_path='', custom_dir=''):
"""
Pull out artist and track info from a Bandcamp URL.

Expand All @@ -587,10 +593,13 @@ def scrape_bandcamp_url(url, num_tracks=sys.maxsize, folders=False, custom_path=
album_name = album_data["album_name"]

if folders:
if album_name:
directory = artist + " - " + album_name
if custom_dir:
directory = custom_dir
else:
directory = artist
if album_name:
directory = artist + " - " + album_name
else:
directory = artist
directory = sanitize_filename(directory)
directory = join(custom_path, directory)
if not exists(directory):
Expand Down