Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft - Update, Late, Fixed. #3856

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JesusLuvsYooh
Copy link
Contributor

Needs renaming, and better comments/tooltip.

Screenshot_2024-07-06_at_19 27 50

Needs renaming, and better comments/tooltip.
Quick words adjustment.
Copy link
Collaborator

@MrGadget1024 MrGadget1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consolidate to base what you can, maybe with virtual methods

@@ -58,6 +58,21 @@ void LateUpdate()
else if (isClient && IsClientWithAuthority) UpdateClientBroadcast();
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

This code was moved to UpdateCall

Comment on lines +61 to +65
void FixedUpdate()
{
if (updateMethod == UpdateMethod.FixedUpdate)
UpdateCall();
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to Base

@miwarnec
Copy link
Collaborator

miwarnec commented Jul 9, 2024

From discord:

  • we don't need Update(), only LateUpdate and FixedUpdate
  • need to change Time.deltaTIme to Time.fixedDeltaTime in case of fixedupdate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants