Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: running code cleanup on all scripts #640

Merged
merged 6 commits into from
Mar 4, 2021
Merged

style: running code cleanup on all scripts #640

merged 6 commits into from
Mar 4, 2021

Conversation

James-Frowen
Copy link
Member

@James-Frowen James-Frowen commented Mar 1, 2021

Each fix is in its own commit, some has nothing to fix

Fixers:

  • Apply object/collection initialization preferences
  • Format document
  • Apply 'this'. qualification preferences
  • Sorting usings
  • Removing unnecessary usings
  • Apply implicit/explicit preferences
  • Removing unused variables
  • Removing unnecessary casts
  • Apply inline 'out' variables preferences
  • Sorting accessibility modifiers

@James-Frowen James-Frowen changed the title Code cleanup style: Running code cleanup on all scripts Mar 1, 2021
@James-Frowen James-Frowen marked this pull request as ready for review March 1, 2021 16:13
@uweeby uweeby changed the title style: Running code cleanup on all scripts style: running code cleanup on all scripts Mar 1, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2021

@uweeby
Copy link
Member

uweeby commented Mar 1, 2021

I dont run any formatting tools and just get whatever VS has by default. I know @paulpach does though so I want to make sure that these changes wont conflict with what he is already doing. Otherwise we might get another PR to change it back :P

@James-Frowen
Copy link
Member Author

This is easy enough to run so I can do it later on to stop conflicts.

@uweeby uweeby requested a review from paulpach March 3, 2021 21:01
@paulpach paulpach merged commit e11ddc8 into master Mar 4, 2021
@paulpach paulpach deleted the code-cleanup branch March 4, 2021 15:28
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2021

🎉 This PR is included in version 70.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants