GEOPY-2508 #810
Open
GEOPY-2508 #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue form types to reduce complexity
# Conflicts: # geoh5py/ui_json/forms.py # geoh5py/ui_json/ui_json.py
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #810 +/- ##
===========================================
- Coverage 90.86% 90.83% -0.03%
===========================================
Files 113 113
Lines 9871 9911 +40
Branches 1837 1845 +8
===========================================
+ Hits 8969 9003 +34
- Misses 488 491 +3
- Partials 414 417 +3
🚀 New features to boost your workflow:
|
domfournier
commented
Nov 18, 2025
Comment on lines
+141
to
+142
| UidOrNumeric = UUID | float | int | None | ||
| StringOrNumeric = str | float | int |
Contributor
Author
There was a problem hiding this comment.
Move to ui_json.annotations. I would like to eventually remove this module when we deprecate Params
|
|
||
|
|
||
| # pylint: disable=too-many-return-statements | ||
| # pylint: disable=too-many-return-statements, too-many-branches |
Contributor
Author
There was a problem hiding this comment.
Move the exception at the function level instead of the entire file. Will be easier to refactor later.
| StringOrNumeric = str | float | int | ||
|
|
||
|
|
||
| def uuid_to_string_or_numeric( |
Contributor
Author
There was a problem hiding this comment.
Move to ui_json.utils
| return self.value | ||
|
|
||
|
|
||
| OptionalUUIDList = Annotated[ |
Contributor
Author
There was a problem hiding this comment.
Also move to ui_json.annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.