Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed at must be NULL #415

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Removed at must be NULL #415

merged 1 commit into from
Oct 19, 2023

Conversation

tifrel
Copy link
Member

@tifrel tifrel commented Oct 19, 2023

No description provided.

@tifrel tifrel marked this pull request as ready for review October 19, 2023 12:30
@github-actions github-actions bot temporarily deployed to production October 19, 2023 12:34 Inactive
@tifrel tifrel merged commit 2b953ba into beta Oct 19, 2023
7 checks passed
@tifrel tifrel deleted the fix-accountid-by-pubkey branch October 19, 2023 12:44
bh2smith
bh2smith reviewed Oct 19, 2023
View reviewed changes
tmp.sh
@@ -0,0 +1,23 @@
NODE_URL='https://rpc.ankr.com/eth'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think change is not intended to be here.

bh2smith
bh2smith reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you have accidentally committed a shell script for converting (block_number, transaction_index) to transaction hash here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bh2smith bh2smith bh2smith left review comments

@sainthiago sainthiago sainthiago approved these changes

@SurgeCode SurgeCode Awaiting requested review from SurgeCode SurgeCode is a code owner

@rubenmarcus rubenmarcus Awaiting requested review from rubenmarcus rubenmarcus is a code owner

@cif cif Awaiting requested review from cif

@microchipgnu microchipgnu Awaiting requested review from microchipgnu microchipgnu is a code owner

@nategeier nategeier Awaiting requested review from nategeier nategeier is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tifrel @sainthiago @bh2smith