Skip to content

Commit

Permalink
Add xmldoc mention about performance overhead of PerformOnSelection()
Browse files Browse the repository at this point in the history
  • Loading branch information
bdach committed Jun 4, 2024
1 parent f13ca28 commit ecfcf7a
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions osu.Game/Screens/Edit/EditorBeatmap.cs
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,11 @@ public ControlPointInfo ControlPointInfo
/// Perform the provided action on every selected hitobject.
/// Changes will be grouped as one history action.
/// </summary>
/// <remarks>
/// Note that this incurs a full state save, and as such requires the entire beatmap to be encoded, etc.
/// Very frequent use of this method (e.g. once a frame) is most discouraged.
/// If there is need to do so, use local precondition checks to eliminate changes that are known to be no-ops.
/// </remarks>
/// <param name="action">The action to perform.</param>
public void PerformOnSelection(Action<HitObject> action)
{
Expand Down

0 comments on commit ecfcf7a

Please sign in to comment.