Merge pull request ppy#28383 from peppy/fix-main-menu-test-fail

Fix occasional test failures on new menu content tests
MingxuanGame · Jun 3, 2024 · 7b14c77 · 7b14c77
2 parents 8296e63 + 9651413
commit 7b14c77
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/osu.Game/Screens/Menu/OnlineMenuBanner.cs b/osu.Game/Screens/Menu/OnlineMenuBanner.cs
@@ -77,7 +77,15 @@ private void checkForUpdates()
                         return;
 
                     if (r.IsCompletedSuccessfully)
-                        Schedule(() => Current.Value = request.ResponseObject);
+                    {
+                        Schedule(() =>
+                        {
+                            if (!FetchOnlineContent)
+                                return;
+
+                            Current.Value = request.ResponseObject;
+                        });
+                    }
 
                     // if the request failed, "observe" the exception.
                     // it isn't very important why this failed, as it's only for display.