Skip to content

Add automatic restart on crash#287

Merged
sandain merged 8 commits intomainfrom
automatic-restarts
Jun 3, 2021
Merged

Add automatic restart on crash#287
sandain merged 8 commits intomainfrom
automatic-restarts

Conversation

@michael2847
Copy link
Member

@michael2847 michael2847 commented Apr 25, 2021

Continuation of #271. Code should be re-based and clean now (and updated to reflect the new true_value function), please let me know if you find anything! :)

@sandain
Copy link
Member

sandain commented Apr 27, 2021

Thanks for updating the PR. Initial inspection looks good. I'll try to give this a test as soon as I can.

@sandain
Copy link
Member

sandain commented May 3, 2021

This looks reasonable to me. I'll try to dedicate some time to giving this a try. Thanks for updating the patch.

@sandain sandain linked an issue May 4, 2021 that may be closed by this pull request
@sandain
Copy link
Member

sandain commented Jun 2, 2021

Sorry, I haven't spent any time testing this yet. I think we should try to get this merged before we get the fixshellcheck branch merged to avoid having to rebase this again. This seems pretty straight forward, but I'm not sure how to test that it is working. Do you just kill the java process? My servers never crash (but I don't have any users anymore either)...
@zanix what do you think about merging this as-is?

@zanix
Copy link
Member

zanix commented Jun 2, 2021

Sorry, I haven't spent any time testing this yet. I think we should try to get this merged before we get the fixshellcheck branch merged to avoid having to rebase this again. This seems pretty straight forward, but I'm not sure how to test that it is working. Do you just kill the java process? My servers never crash (but I don't have any users anymore either)...
@zanix what do you think about merging this as-is?

I think you can just kill the process. I haven't been able to test either and I also do not have active users on a server.
This looks straightforward to me as well, it's probably safe to merge.

@sandain sandain merged commit ee00f9a into main Jun 3, 2021
@michael2847 michael2847 deleted the automatic-restarts branch January 9, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adding a way to monitor server crash and automatically restart

3 participants