Conversation
Member
|
Nice, now hopefully I can find time to test this |
Member
|
yes, i will test this as well, thanks for the PR @sandain ! |
Member
Author
|
Has anyone had the chance to test this? I'm not having any issues with it, but I don't have time to play this game any more, so I haven't fully tested this change. All I have time to check for is whether the server starts and whether I get a valid query back from the server, and both work just fine. |
Member
|
Not yet, haven't had time |
Member
|
just tested this and it works nicely! |
Member
Author
|
Thanks for testing @Roflicide and @zanix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add and use method to check true/false values. Inspired by PR #271 from @Roflicide