Implemented modular SubMod loading #90
Conversation
FiskFille
commented
Apr 3, 2019
FiskFille
commented
- the config UI that comes with it
|
|
||
| LOGGER.info("Loaded submod {} from class {}.", modName, data.getClassName()); | ||
| } | ||
| else if (!requiresMcRestart) |
There was a problem hiding this comment.
Why does requiring a restart prevent it from being registered into the event bus, these seem like completely isolated properties?
There was a problem hiding this comment.
Since event handlers can't be unregistered, they're only registered for that submod if
A) it's loaded during startup (L56), or
B) it won't require a restart.
Submods that don't require a restart are expected to limit their features to when they're enabled, so they get their handlers registered on init regardless if they're enabled or not.
| return INSTANCE.loadedSubMods.contains(INSTANCE.subMods.get(subMod)); | ||
| } | ||
|
|
||
| public static boolean unload(ISubMod subMod) |
There was a problem hiding this comment.
Event listeners of the sub mod (registered by default by this PR) are not unregistered when it is unloaded?
There was a problem hiding this comment.
Event handlers are dynamically generated using ASM by Forge, so unregistering one post-init wouldn't change anything.
