Lint cleanups and a minor TiC plugin API change to restrict references to TiC internals to MMDLib #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to Tinkers Construct code almost entirely into the MMDLib side of things. The last remaining direct reference is to the 'MaterialTypes' set of constants - something I am unsure of how to actually resolve. The TraitRegisty is to be used for all access to registered traits - every custom trait in *Metals is in it as well as it autiomatically importing all default Tinkers' Construct traits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some lint cleanups and a change to the API that moves direct references to Tinkers Construct code almost entirely into the MMDLib side of things. The last remaining direct reference is to the 'MaterialTypes' set of constants - something I am unsure of how to actually resolve.
The TraitRegisty is to be used for all access to registered traits - every custom trait in *Metals is in it as well
as it autiomatically importing all default Tinkers' Construct traits.