Skip to content

Conversation

@TheCurle
Copy link
Member

With Discord making "read messages" a privileged intent in the somewhat near future, it's clear they want us to move to slash commands.

Now that we have chewutils, it's pretty easy to move things over.

I'm trying to keep everything with feature parity, but improving and fixing things where necessary.
Notably, the forge and mute commands, where the first wasn't accepted the parameter it advertised, and the latter was improved with the addition of Options:
image

I also implemented a PaginatedCommand helper for the multiple commands whose contents can exceed the maximum embed length. This will be refactored into all necessary commands as needed.

Tricks and Quotes will require some thought, as i have had some extra features requested that would fit well with this refactor.
I'll explain in a comment.

I'm currently about half way through moving all of the commands over.

@sciwhiz12 sciwhiz12 added enhancement java Pull requests that update Java code labels Oct 17, 2021
@sciwhiz12
Copy link
Collaborator

I would like to note that even though the Read Messages intent will become privileged in the future, to my knoweldge it will operate the same as any other privileged intent: only requiring bot verification if the bot reaches 100 servers. So this doesn't affect us as much, given that MMDBot/Kiri is only present in the MMD server.

@TheCurle
Copy link
Member Author

I indeed did intend this by pointing out that it'll be Privileged, but again, it's clear that Discord wants all bots to use this, and there's nothing stopping us right now.

@TheCurle
Copy link
Member Author

TheCurle commented Oct 18, 2021

A couple of notes:

This PR closes one of the TODO List items;

Replace help command system (which currently forces help info to DMs)

Was already done by my last two PRs.

OldChannels command: Non-existing channel/category reply ${channel/category}

Incidental fix from this rewrite.

The refactor to move all of the Quote related commands into one large command seems to work pretty well, and i intend to do the same with tricks in the near future.
I'll likely migrate both to the SQLite database at the same time for ease of developability.

A bunch of incidental bugs were fixed along the way, and javadocs on all of the command classes were changed to actually sum up what the commands were and how they could be used.

This was a surprising amount of fun to do, thanks to the MMD team for the opportunity to work on this.
To the future (and a ton more PRs)!

@TheCurle TheCurle marked this pull request as ready for review October 18, 2021 00:55
@TheCurle
Copy link
Member Author

Since i had some spare time, i took the liberty of ticking another thing off the todo list:

Add account creation date to join and ban embeds

The Join embed already has this, i added the same logic to the Ban embed.

Copy link
Contributor

@antoinegag antoinegag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks here and there because I'm nosy :P

@jriwanek jriwanek merged commit 2868deb into MinecraftModDevelopment:3.0 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants