-
Notifications
You must be signed in to change notification settings - Fork 10
Refactor to use slash commands. #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I would like to note that even though the Read Messages intent will become privileged in the future, to my knoweldge it will operate the same as any other privileged intent: only requiring bot verification if the bot reaches 100 servers. So this doesn't affect us as much, given that MMDBot/Kiri is only present in the MMD server. |
|
I indeed did intend this by pointing out that it'll be Privileged, but again, it's clear that Discord wants all bots to use this, and there's nothing stopping us right now. |
# Conflicts: # src/main/java/com/mcmoddev/mmdbot/modules/commands/CommandModule.java
|
A couple of notes: This PR closes one of the TODO List items;
Was already done by my last two PRs.
Incidental fix from this rewrite. The refactor to move all of the Quote related commands into one large command seems to work pretty well, and i intend to do the same with tricks in the near future. A bunch of incidental bugs were fixed along the way, and javadocs on all of the command classes were changed to actually sum up what the commands were and how they could be used. This was a surprising amount of fun to do, thanks to the MMD team for the opportunity to work on this. |
|
Since i had some spare time, i took the liberty of ticking another thing off the todo list:
The Join embed already has this, i added the same logic to the Ban embed. |
antoinegag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpicks here and there because I'm nosy :P
With Discord making "read messages" a privileged intent in the somewhat near future, it's clear they want us to move to slash commands.
Now that we have chewutils, it's pretty easy to move things over.
I'm trying to keep everything with feature parity, but improving and fixing things where necessary.

Notably, the forge and mute commands, where the first wasn't accepted the parameter it advertised, and the latter was improved with the addition of Options:
I also implemented a PaginatedCommand helper for the multiple commands whose contents can exceed the maximum embed length. This will be refactored into all necessary commands as needed.
Tricks and Quotes will require some thought, as i have had some extra features requested that would fit well with this refactor.
I'll explain in a comment.
I'm currently about half way through moving all of the commands over.