Improve help command with embeds and pagination. #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current help command is in dire need of attention.
Primarily, it operates by sending a DM to the user that asked for help.
That is poor user interface in general, but it does it by just dumping a wall of text that is very hard to parse.
This PR changes the help system greatly, using an almost identical system to the existing pagination that i created for quotes.
It replies to the help request in the same channel, using an embed that looks not dissimilar from the following:
The scroll button at the bottom is only added if there are enough commands to warrant it, as seen here with the bot i was using to test this new feature:
There is the disadvantage of removing the command categorization, but as per my discussion with @ProxyNeko, this doesn't seem to be such a disadvantage due to the poor state of the categorization system anyway.
Regardless, this could be easily refactored in the future to reincorporate it.
From some mild testing, this feature seems to be just about as stable as the quote list command is is based on, so there shouldn't be many issues stemming from this.
Thanks.