Mini Cleanup. #70
Merged
Mini Cleanup. #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciwhiz12
reviewed
Aug 10, 2021
src/main/java/com/mcmoddev/mmdbot/modules/commands/server/quotes/CmdGetQuote.java
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/commands/bot/info/CmdUptime.java
Outdated
Show resolved
Hide resolved
sciwhiz12
approved these changes
Sep 1, 2021
…eTime to maintain regularity with UTC.
TheCurle
force-pushed
the
3.0-mini-cleanup
branch
from
af3a5b3 to
0881667
Compare
sciwhiz12
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable additions:
Bugs fixed:
Quotes with too many arguments are allowed.
Quote messages that don't end with a
"are allowed.Random quotes don't pick the most recent quote.
Random quotes can choose an invalid quote.
Snowflake IDs used for author attribution in a quote can lead to strangeness:
Utils#timeDifference can return no text if the amount of time is unrepresentable.
Other miscellaneous changes: