Skip to content

Conversation

@Matyrobbrt
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

@Matyrobbrt Matyrobbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine

Copy link
Member

@TheCurle TheCurle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clear that a lot of effort has been put into this.
Without being able to test the scripting portions (due to my computer situation), i can't verify how well it works, so i trust your testing process.

That being said, i do like the contexts and items that you expose to the scripting engine.
You should think about how this can be abused, though:

  • Would a user be able to use a script trick to spam a message in a channel?
  • Could you potentially get a list of channels in the guild? That'd be a bad idea.
  • Does the script expose the ability to embed images?

Other than those thoughts, this looks good to me.

@Matyrobbrt
Copy link
Collaborator Author

Matyrobbrt commented Feb 6, 2022

Could you potentially get a list of channels in the guild?

Yes, but you can only get the channel's name and ID, and you cannot send anything in it. You can only send messages in the channel the evaluation was executed.

Does the script expose the ability to embed images?

If you mean "embed image" by making the bot send a link yes. But making an embed is not possible unless you have the needed perms.

Would a user be able to use a script trick to spam a message in a channel?

This is a good point, so I should actually timeout the evaluation after 4 seconds

@Matyrobbrt Matyrobbrt requested a review from TheCurle February 6, 2022 17:39
@KiriCattus KiriCattus merged commit dbf0e6a into MinecraftModDevelopment:3.0 Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants