-
Notifications
You must be signed in to change notification settings - Fork 10
3.9: Scripting #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.9: Scripting #132
Conversation
Matyrobbrt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is fine
TheCurle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's clear that a lot of effort has been put into this.
Without being able to test the scripting portions (due to my computer situation), i can't verify how well it works, so i trust your testing process.
That being said, i do like the contexts and items that you expose to the scripting engine.
You should think about how this can be abused, though:
- Would a user be able to use a script trick to spam a message in a channel?
- Could you potentially get a list of channels in the guild? That'd be a bad idea.
- Does the script expose the ability to embed images?
Other than those thoughts, this looks good to me.
src/main/java/com/mcmoddev/mmdbot/modules/commands/community/CmdEvaluate.java
Outdated
Show resolved
Hide resolved
...java/com/mcmoddev/mmdbot/modules/commands/community/contextmenu/message/ContextMenuGist.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/utilities/dictionary/DictionaryUtils.java
Outdated
Show resolved
Hide resolved
Yes, but you can only get the channel's name and ID, and you cannot send anything in it. You can only send messages in the channel the evaluation was executed.
If you mean "embed image" by making the bot send a link yes. But making an embed is not possible unless you have the needed perms.
This is a good point, so I should actually timeout the evaluation after 4 seconds |
No description provided.