-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for CSV mapping files #29
Comments
That's not what MCPConfig is for though... See #23 (comment) |
Isn't this tool partially a replacement for MCP? And what should you do otherwise to apply the CSV mappings? |
False |
How in the world you took somewhat opening up the SRG files to being replacing MCP I don't know. How about use the same tools that have been used since forever? (SpecialSource, though eventually I'd like to see that replaced :p) |
MCPConfig is EXPLICITLY designed to NOT be a replacement for MCP. Please respect my wishes and don't do this. And to that end, I will not allow you to promote you doing it in this repo so i have removed your link. |
I am sorry. It was not my goal to reenable modifying the base game jar. I was rather looking for a tool which is able to decompile Minecraft and apply mappings so I can look at the code (for Mojira), and MCPConfig looked well suited for this task because you did a great job at providing the latest SRG / TSRG mappings and it sets up settings for the IDE. I know that there are other tools, for example SpecialSource (as mentioned by @jamierocks), which however is not able to insert documentation, or ForgeGradle 3.0, but I am not sure if this can solve my problem. Apparently there is also Srg2Source but it looks like it does not support insertion of documentation either. Additionally, is there a place where you can get the latest SRG mappings? MCPConfig is more than that and is not as easy to query as a JSON file listing the existing mappings (similar to how it is done for the CSV mappings). Forge maven had the SRG mappings for previous versions, but apparently 1.12.2 is the latest. Sorry if this got too off-topic. |
Firstly, the documentation provided by MCP isn't very good anymore - its largely the same as its been for a number of releases, and therefor the reliability of it isn't so great anymore (Mojang obviously change stuff).
You kinda seem to contradict yourself - earlier on saying "you did a great job at providing the latest SRG / TSRG mappings". I'm not sure what you mean by this.
No, well mostly no - only class names are done by hand. The SRG mappings are generated by retroguard (pending a replacement). They are updated version-to-version by a proprietary tool (again pending a replacement).
I think it has :p |
The mappings are still actively maintained, see MCPBot-Issues.
I should probably have written "is there another place where you can get the latest SRG mappings?". Are they provided on Forge Maven together with a JSON file which lists all versions like it is the case for the CSV mappings, or is this Github project the only source? |
I'm well aware, the mappings aren't what I was referring to - the javadocs were.
Lex'll have to answer that one, I know that it builds zips with the mappings within but I'm not sure if they're deployed anywhere. |
Since there is currently no support for CSV mapping files I created the project [removed]. The
README
file should hopefully explain it a little bit (might not display correctly at the moment because Github has some issues).Let me know if there is interest in using the project or parts of it for MCPConfig.
The text was updated successfully, but these errors were encountered: