-
-
Notifications
You must be signed in to change notification settings - Fork 447
Switch to DiffPatch #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to DiffPatch #710
Conversation
|
canonicalizeAccess is something that needs to be kept as discussed on discord, as modders have access transformers which will effect the patches. |
LexManos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Binary compat is a important thing, even if it is just adding a bunch of bouncer lines like you already do for most of the tasks. Also, we would need to specify somewhere in the userdev config what type of patch files we are using. As the old implementation {and other consumers of the userdev jar} have no idea about this relative header... Unless we want to bake the headers during userdev jar creation...
src/mcp/java/net/minecraftforge/gradle/mcp/function/PatchFunction.java
Outdated
Show resolved
Hide resolved
src/mcp/java/net/minecraftforge/gradle/mcp/function/PatchFunction.java
Outdated
Show resolved
Hide resolved
src/mcp/java/net/minecraftforge/gradle/mcp/function/PatchFunction.java
Outdated
Show resolved
Hide resolved
src/userdev/java/net/minecraftforge/gradle/userdev/MinecraftUserRepo.java
Outdated
Show resolved
Hide resolved
b41d466 to
ddc2c33
Compare
|
This should be ready for more review, all comments have been addressed. |
835a865 to
2237127
Compare
ffb41cc to
b525e75
Compare
Switch to DiffPatch.
Benifits:
@@ -start1,len1 _,len2 @@)Currently, DiffPatch is on my own maven until we get review out of the way and throw them on Forge's maven.
Recommended bump to FG 3.1 as this slightly changes the generated patch output in some cases (chooses different context).
Patches are 'baked' for userDev jars to maintain compat with older FG versions.