Fix loading ATs from classpath mods #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method signature for
ModAccessTransformer#addJarchanged:MinecraftForge/MinecraftForge@9d0771b#diff-d7c0a2bc3372b61d6a3e347ad77f1595L62
This updates
GradleForgeHacksto work with the new method signature, and maintains backward compatibility for the old method signature.This PR fixes issues like mezz/JustEnoughItems#1190 where a jar with ATs is loaded from the classpath, but the ATs were not discovered and applied.