Temporary fix to handle loop that won't inline its condition#100
Merged
LexManos merged 1 commit intoMinecraftForge:masterfrom Jun 2, 2021
Merged
Temporary fix to handle loop that won't inline its condition#100LexManos merged 1 commit intoMinecraftForge:masterfrom
LexManos merged 1 commit intoMinecraftForge:masterfrom
Conversation
Fixes MinecraftForge#89 Co-Authored-By: Geolykt <admin@geolykt.de>
Member
|
The deeper I go into dissecting IfHelper, the more I have the urge to re-write it all. That system could be a lot more sane. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89, using the fix provided by Geolykt as a temporary solution.
Eventually someone should figure out why these loop conditions are not being properly inlined, but this helps get MC compiling.
diff
1.16.5: no change
21w19a: